Michael Tokarev via Postfix-users:
> Noticed a small error in postfix-script.  The change is
> in sed expression - 's/,/ /' vs 'y/,/ /'.  This isn't
> really important (it only suppresses extra check of
> a few dirs which are normally done for default instance
> only), but it's better to fix it.

You did not mention what the problem is. Is the problem that the
existing script does not replace multiple commas?

In that case I prefer 's/,/ /g' as that is more idiomatic for the
rest of Postfix code.

(I prefer not to use the "tr" command, because some implementations
require arguments enclosed in '[]' and some do not).

        Wietse

> Signed-off-by: Michael Tokarev <m...@tls.msk.ru> 
> 
> diff --git a/conf/postfix-script b/conf/postfix-script
> index c43d764f..de86d382 100755
> --- a/conf/postfix-script
> +++ b/conf/postfix-script
> @@ -97,7 +97,7 @@ def_config_directory=`$command_directory/postconf -dh 
> config_directory` || {
>  
>  instances=`test ! -f $def_config_directory/main.cf ||
>      $command_directory/postconf -qc $def_config_directory \
> -    -h multi_instance_directories | sed 's/,/ /'` || {
> +    -h multi_instance_directories | sed 'y/,/ /'` || {
>       $FATAL cannot execute $command_directory/postconf!
>       exit 1
>  }
> _______________________________________________
> Postfix-users mailing list -- postfix-users@postfix.org
> To unsubscribe send an email to postfix-users-le...@postfix.org
> 
_______________________________________________
Postfix-users mailing list -- postfix-users@postfix.org
To unsubscribe send an email to postfix-users-le...@postfix.org

Reply via email to