Hi Björn,
First, thanks for testing, good luck that you found that small but
important case.
On my thoughts about the issue, I'm attaching two diff, one with
py-jupyter_core and one with py-jupyter_client, the later with a patch
to disable the use of the sticky bit.
The code actually checks if:
"if hasattr(stat, 'S_ISVTX')", so I have to assume that the logical
step would be to extend the "if" to cover our case: We have the sticky
bit, but we can not use it (leaving root aside), so:
"if hasattr(stat, 'S_ISVTX') and not sys.platform.startswith('openbsd'):"The warning is no more on my side, and test are passing, would you care to test the patch ? By the way, just out of curiosity, you use jupyter for something in particular? I'm only updating it to cover the requires to update devel/spyder and it would be good to include you in future updates if you are interested in testing the changes. Thanks. Elias. On Sun, Dec 9, 2018 at 3:42 AM Björn Ketelaars <[email protected]> wrote: > > On Sat 08/12/2018 17:38, Elias M. Mariani wrote: > > py-jupyter_core 4.3.0 to 4.4.0: > > Changelog: > > https://github.com/jupyter/jupyter_core/blob/4.4.0/docs/changelog.rst > > > > - Taking maintainership. (already talked to Alexandr) > > - HOMEPAGE to HTTPS. > > - A little love to the patches to keep working. > > - Regression test: > > > > devel/py-jupyter_core and devel/py-jupyter_core,python3: > > 40 passed > > Same results for 4.3.0 and 4.4.0. > > > > ++++++++++++++++++++ > > py-jupyter_client 5.1.0 to 5.2.3: > > Changelog: > > https://github.com/jupyter/jupyter_client/blob/5.2.3/docs/changelog.rst > > > > .... > > For what it is worth, I prefer to look at two separate diffs instead of > one. Helps me giving feedback. That said: > > Both updates look good, and test ok in an existing jupyter-notebook > setup. However, jupyter_client gives a warning when opening a workbook: > > [I 06:41:46.032 NotebookApp] Kernel started: > 1a170f9c-4d7a-4646-abac-fff4961889d6 > /usr/local/lib/python3.6/site-packages/jupyter_client/connect.py:163: > RuntimeWarning: Failed to set sticky bit on > '/home/bket/.local/share/jupyter/runtime/kernel-1a170f9c-4d7a-4646-abac-fff4961889d6.json': > [Errno 79] Inappropriate file type or format: > '/home/bket/.local/share/jupyter/runtime/kernel-1a170f9c-4d7a-4646-abac-fff4961889d6.json' > Probably not a big deal, but runtime files may be cleaned up periodically. > RuntimeWarning, > > The warning is caused by [1], which tries to set the sticky bit on a > file. On OpenBSD the latter is only allowed by the superuser, see > sticky(8). > Easy fix would be for an user to just ignore the warning. However, I > think the behaviour of jupyter_client is wrong, and should be patched. > What do you think? > > [1] > https://github.com/jupyter/jupyter_client/blob/master/jupyter_client/connect.py#L152
py-jupyter_core-4.4.0.diff
Description: Binary data
py-jupyter_client-5.2.3.diff
Description: Binary data
