On Sat 08/12/2018 17:38, Elias M. Mariani wrote: > py-jupyter_core 4.3.0 to 4.4.0: > Changelog: > https://github.com/jupyter/jupyter_core/blob/4.4.0/docs/changelog.rst > > - Taking maintainership. (already talked to Alexandr) > - HOMEPAGE to HTTPS. > - A little love to the patches to keep working. > - Regression test: > > devel/py-jupyter_core and devel/py-jupyter_core,python3: > 40 passed > Same results for 4.3.0 and 4.4.0. > > ++++++++++++++++++++ > py-jupyter_client 5.1.0 to 5.2.3: > Changelog: > https://github.com/jupyter/jupyter_client/blob/5.2.3/docs/changelog.rst > > ....
For what it is worth, I prefer to look at two separate diffs instead of one. Helps me giving feedback. That said: Both updates look good, and test ok in an existing jupyter-notebook setup. However, jupyter_client gives a warning when opening a workbook: [I 06:41:46.032 NotebookApp] Kernel started: 1a170f9c-4d7a-4646-abac-fff4961889d6 /usr/local/lib/python3.6/site-packages/jupyter_client/connect.py:163: RuntimeWarning: Failed to set sticky bit on '/home/bket/.local/share/jupyter/runtime/kernel-1a170f9c-4d7a-4646-abac-fff4961889d6.json': [Errno 79] Inappropriate file type or format: '/home/bket/.local/share/jupyter/runtime/kernel-1a170f9c-4d7a-4646-abac-fff4961889d6.json' Probably not a big deal, but runtime files may be cleaned up periodically. RuntimeWarning, The warning is caused by [1], which tries to set the sticky bit on a file. On OpenBSD the latter is only allowed by the superuser, see sticky(8). Easy fix would be for an user to just ignore the warning. However, I think the behaviour of jupyter_client is wrong, and should be patched. What do you think? [1] https://github.com/jupyter/jupyter_client/blob/master/jupyter_client/connect.py#L152
