This is really nice - Jacob's and Mikolaj's suggestions are both
very simple, and taken together, they allow to do nearly everything
the u-level could do, but with less code end more elegance...
Jacob Meuser wrote on Thu, Mar 13, 2008 at 08:51:40PM +0000:
> private will start at 1000, and be 1000 + whatever I started from.
That covers the case of private tweaks not to be published -
your own stuff always overriding any public version.
Mikolaj Kucharski wrote on Thu, 13 Mar 2008 20:07:34 +0000:
> I proposed in the past partial patch-level, like p1.1
That covers the case of ongoing development:
What is finally committed overriding any private version.
(I must have missed your past proposal.)
Of course, you need to know beforehand whether today's hacking will
be "Jacob-type" or "Mikolaj-type" such that you can opt for either
p1001 or p1.01, while p1u1 lets you postpone the decision
until p2 comes out - which is indeed a minor point.
> anyway, espie says these discussion are for ports hackathons, so ...
Ok, a few ideas have been collected,
i shall try some of them and wait and see...
Yours,
Ingo
P.S.
Mikolay, probably you have already patched this for yourself,
but just in case - the implementation of your idea is nearly trivial.
But take care, as 1.2 == 1.20 > 1.10 == 1.1, start at p1.001
if you are planning a major effort. ;-)
Index: PackageName.pm
===================================================================
RCS file: /cvs/src/usr.sbin/pkg_add/OpenBSD/PackageName.pm,v
retrieving revision 1.31
diff -u -p -r1.31 PackageName.pm
--- PackageName.pm 23 Aug 2007 09:09:16 -0000 1.31
+++ PackageName.pm 13 Mar 2008 21:44:58 -0000
@@ -88,7 +88,7 @@ sub splitp
{
local $_ = shift;
- if (/^(.*\-\d[^-]*)p(\d+)(.*)$/o) {
+ if (/^(.*\-\d[^-]*)p(\d+(?:\.\d+)?)(.*)$/o) {
return ($1.$3, $2);
} else {
return ($_,-1);
