broulik added inline comments. INLINE COMMENTS
> graesslin wrote in PowerDevilSettings.kcfg:35 > Given the experience with my trackball: I think I used it for another half > year once it dropped below 10 % My trackball has the peculiarity of dropping in 10% or 20% steps, so it might not even trigger then notification when it goes from 20% to 0%. Not sure how to proceed there. > graesslin wrote in powerdevilcore.cpp:508 > In English that's fine, but in e.g. a German translation it would be horrible > to suggest to charge a battery. (For non German speakers: a "Batterie" is the > non-rechargeable one, an "Akku" is the rechargeable one). Given that it needs > i18nc I never explained "Battery" anywhere and they always got it right. (I could show a different text depending on whether it reports the battery as "rechargeable", not sure how reliable that property is, though ;)) > graesslin wrote in GeneralPage.cpp:123 > new connect syntax? I wanted to but the signature doesn't match so I would have had to cramp a lambda in there. Might change that at a later point (where I'll adjust the other connects too) REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: graesslin, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
