broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ...Initial support for peripheral battery notifications
  
  When the battery in a non-power supply battery drops below 10% it emits a 
notification.
  
  Missing:
  
  - Don't notify when battery is not present (otherwise will have 0%)
  - Notify when new device is plugged in
  - Messages for other batteries than mouse and keyboard(?)
  
  It does not yet chec
  
  Initial support for peripheral battery notifications
  
  When the battery in a non-power supply battery drops below 10% it emits a 
notification.
  
  Missing:
  
  - Don't notify when battery is not present (otherwise will have 0%)
  - Notify when new device is plugged in
  - Messages for other batteries than mouse and keyboard(?)
  
  It does not yet chec
  
  [Profiles KCM] Add spinbox for changing the low peripheral battery threshold
  
  Notify about low peripheral devices on startup similar to what we do with the 
laptop battery
  
  Improve wording of notifications
  
  Always show the name of the device. It might by cryptic, so we'll have to
  monitor how that turns out. In any case the affected device type (mouse, 
keyboard, ...)
  is indicated by both the icon and the notification body text.
  
  Remove m_batteriesUdi QStringList
  
  We can just use the keys of m_batteriesPercent instead like
  we already do for peripheral devices
  
  Merge branch 'broulik/notifyPeripherals' of git://anongit.kde.org/powerdevil 
into broulik/notifyPeripherals
  
  Notify about low peripherals when plugging them in
  
  Unfortunately my mouse reports info only periodically, so when plugging
  it in it is always "not present" and 0%, so it doesn't show for me.
  Also, when the device is really empty (so won't work) it won't show
  anything either because it won't be "present". Oh, well...

TEST PLAN
  So far I have only tested this with my mouse on a desktop computer,
  starting kded5 brings the notification. Needs more testing with a laptop so it
  didn't break the default battery handling

REPOSITORY
  rPOWERDEVIL Powerdevil

BRANCH
  broulik/notifyPeripherals

REVISION DETAIL
  https://phabricator.kde.org/D1735

AFFECTED FILES
  PowerDevilSettings.kcfg
  daemon/powerdevilcore.cpp
  daemon/powerdevilcore.h
  kcmodule/global/GeneralPage.cpp
  kcmodule/global/generalPage.ui
  powerdevil.notifyrc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to