graesslin added inline comments.
INLINE COMMENTS
> PowerDevilSettings.kcfg:35
> + <entry name="PeripheralBatteryLowLevel" type="Int">
> + <default>10</default>
> + </entry>
Given the experience with my trackball: I think I used it for another half year
once it dropped below 10 %
> powerdevilcore.cpp:508
> + msg = i18n("The battery in your keyboard is low, and the
> device may turn itself off at any time. "
> + "Please replace or charge the battery as soon as
> possible.");
> + icon = QStringLiteral("input-keyboard");
In English that's fine, but in e.g. a German translation it would be horrible
to suggest to charge a battery. (For non German speakers: a "Batterie" is the
non-rechargeable one, an "Akku" is the rechargeable one). Given that it needs
i18nc
> GeneralPage.cpp:123
> connect(criticalSpin, SIGNAL(valueChanged(int)), SLOT(changed()));
> + connect(lowPeripheralSpin, SIGNAL(valueChanged(int)), SLOT(changed()));
>
new connect syntax?
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D1735
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design
Cc: graesslin, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
