meven added inline comments.
INLINE COMMENTS
> MenuModel.cpp:26
> #include "MenuItem.h"
> -
> +#include <QDebug>
>
not needed
> ModuleView.cpp:349
> if (activeModule) {
> -
> KActivities::ResourceInstance::notifyAccessed(QUrl(QStringLiteral("kcm:") +
> activeModule->moduleInfo().service()->storageId()),
> - QStringLiteral("org.kde.systemsettings"));
> + if (d->mSaveStatistics) {
> +
> KActivities::ResourceInstance::notifyAccessed(QUrl(QStringLiteral("kcm:") +
> activeModule->moduleInfo().service()->storageId()),
We might want to have a different url scheme like "kinfo" insteat of "kcm" and
"org.kde.kinfocenter" instead of "org.kde.systemsettings"
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D26895
To: mart, #plasma
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n,
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, ahiemstra, mart
