davidedmundson added inline comments.
INLINE COMMENTS
> SettingsBase.h:48
> + // This has effect only if set right after the ctor
> + void setInfoCenterMode(bool set);
> bool queryClose() override;
why not an arg in the ctor then?
> SettingsBase.h:95
> + MenuItem * homeModule = nullptr;
> MenuItem * lostFound = nullptr;
> KService::List categories;
what happens to lost and found modules
> main.cpp:57
> QCommandLineParser parser;
> + QCommandLineOption infoCenterOption(QStringList() << QStringLiteral("i")
> << QStringLiteral("showInformation"),
> + i18n("Show System information
> instead of System configuration."));
As an alternative, we could switch based on our binary name, from arg[0] and
then install a symlink.
Then we have 100% compatibility
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D26895
To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
ahiemstra, mart
