broulik added a comment.
Great idea!
INLINE COMMENTS
> SettingsBase.h:100
> KAboutApplicationDialog * aboutDialog = nullptr;
> + bool m_infoCenterMode = false;
> };
I would prefer this to be an enum
> main.cpp:66
> + if (infoCenterMode) {
> + QCoreApplication::setApplicationName(QStringLiteral("kinfocenter"));
> + application.setApplicationName(QStringLiteral("kinfocenter"));
Can we not just create a different `KAboutData` instance?
> main.cpp:71
> + aboutData.setDesktopFileName(QStringLiteral("org.kde.kinfocenter"));
> + aboutData.setShortDescription(QStringLiteral("Centralized and
> convenient overview of system information"));
> +
> application.setWindowIcon(QIcon::fromTheme(QStringLiteral("hwinfo")));
`i18n`
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D26895
To: mart, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
