On Thu, 21 Feb 2013 17:28:06 +0100 Sebastian Ramacher wrote: [...] > On 2013-02-20 23:04:06, Francesco Poli wrote: > > Hello again, > > since I am not satisfied with the "workaround" suggested by upstream > > and mentioned in <http://bugs.debian.org/700189#64>, I am trying to see > > whether I can come up with a patch that makes gnome-mplayer avoid > > passing the "-volume" option to mplayer in certain situations. > > > > When I saw the "use_volume_option" variable in src/main.c:1309, > > I thought I found the way to do it: it seemed that setting that > > variable to FALSE could disable the use of the "-volume" option in the > > mplayer command line. > > > > I tried to modify the src/main.c accordingly, but it seems to me that > > the "use_volume_option" variable has no effect at all. > > It is indeed 0 (checked with gdb), but the mplayer command line still > > includes the "-volume" option... > > Before this issue drives me completely crazy, could you please clarify > > what's wrong in my reasoning? > > Is the "use_volume_option" variable actually used for anything? > > Is there an easy way to disable the passing of the "-volume" option to > > mplayer (without a major code overhaul)? > > The options passed to mplayer are assembled in gmtk.
Yes, I found that out. Thanks anyway for kindly explaining this to me. > The function you're > looking for is launch_mplayer in src/gmtk_media_player.c. Just grep for > "-volume" in that file. Sure, but I would like to decide *inside gnome-mplayer* whether gmtk should or should not pass the "-volume" option to mplayer. The "use_volume_option" identifier seemed to suggest that this variable was used exactly for that purpose. Otherwise, why assigning to it a boolean value returned by the detect_volume_option() function?!? What is the actual purpose of the "use_volume_option" variable? I cannot find it referenced anywhere else than in gnome-mplayer/src/main.c ... It does not seem to be in any way accessible from gmtk ... > > (I'm not sure if it's enough to just patch out "-volume". There is some > interaction between the volume control widget and mplayer too.) That's a reasonable concern. I have the same concern myself. I was trying to test what would happen, but, as I said, it seems that the "use_volume_option" variable has no effect at all. > > Hope that helps A little, thanks a lot for your fast reply. -- http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt New GnuPG key, see the transition document! ..................................................... Francesco Poli . GnuPG key fpr == CA01 1147 9CD2 EFDF FB82 3925 3E1C 27E1 1F69 BFFE
pgpW3y9qgZO1G.pgp
Description: PGP signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
