On 06/13/2013 11:16 AM, Peter Eisentraut wrote: > This has served no purpose except to > > 1. take up space > 2. confuse users > 3. produce broken external extension modules that take contrib as an example > 4. break builds of PostgreSQL when users try to fix 3. by exporting USE_PGXS
Weak -1 from me; I find being able to build contrib modules using PGXS from the source tree extremely useful in development. It allows me to easily install an extension from a newer Pg version into an older server, test against older servers, etc. What about assuming USE_PGXS=1 if it's unset, and have recursive make set USE_PGXS=0 explicitly when invoking contrib makefiles? There'd be a behaviour change, in that you'd have to write USE_PGXS=0 when you wanted the module to build against the tree it was currently in instead of with pgxs. Maybe that's just as confusing. If everyone hates that idea I can just write a 'pgxs' command that copies the Makefile, hacks it to use PGXS, and runs it, so it's not like I lose anything critical. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
