On Wed, Sep 30, 2009 at 21:38, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: >> I can certainly review the win32 encoding patch, but I was rather >> hoping for some comments from others on if we're interested in a win32 >> only solution, or if we want something more generic. Should we just go >> with the win32-only one for now? > > That was actually the only substantive comment I had about it. I don't > see why it's a win32-only problem or why a win32-only solution is a good > approach.
Yeah, that's my thought as well. If we want a complete one, we should reject this patch and ask for one that does that. If we are fine with a win32 only one, I can review this one and get it in. I'm leaning towards us wanting a general one, but I'm unsure how much work that will take. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers