On Mon, Jul 19, 2021 at 1:00 PM Peter Smith <smithpb2...@gmail.com> wrote: > > On Mon, Jul 19, 2021 at 4:41 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > > > OK. I have implemented this reported [1] potential buffer overrun > > > using the constraining strlcpy, because the GID limitation of 200 > > > bytes is already mentioned in the documentation [2]. > > > > > > > This will work but I think it is better to use sizeof gid buffer as we > > are using in ParseCommitRecord() and ParseAbortRecord(). Tomorrow, if > > due to some unforeseen reason if we change the size of gid buffer to > > be different than the GIDSIZE then it will work seamlessly. > > > > Modified as requested. PSA patch v2. >
LGTM. I'll push this tomorrow unless Tom or someone else has any comments. -- With Regards, Amit Kapila.
