On Fri, Jul 30, 2021 at 3:18 PM vignesh C <vignes...@gmail.com> wrote: > > On Fri, Jul 30, 2021 at 9:32 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > Please find attached the latest patch set v100* > > > > v99-0002 --> v100-0001 > > > > Differences: > > > > * Rebased to HEAD @ today (needed because some recent commits [1][2] broke > > v99) > > > > The patch applies neatly, tests passes and documentation looks good. > A Few minor comments. > 1) This blank line is not required: > +-- two_phase and streaming are compatible. > +CREATE SUBSCRIPTION regress_testsub CONNECTION > 'dbname=regress_doesnotexist' PUBLICATION testpub WITH (connect = > false, streaming = true, two_phase = true); > + >
Fixed in v101. > 2) Few points have punctuation mark and few don't have, we can make it > consistent: > +############################### > +# Test 2PC PREPARE / ROLLBACK PREPARED. > +# 1. Table is deleted back to 2 rows which are replicated on subscriber. > +# 2. Data is streamed using 2PC > +# 3. Do rollback prepared. > +# > +# Expect data rolls back leaving only the original 2 rows. > +############################### > Fixed in v101. > 3) similarly here too: > +############################### > +# Do INSERT after the PREPARE but before ROLLBACK PREPARED. > +# 1. Table is deleted back to 2 rows which are replicated on subscriber. > +# 2. Data is streamed using 2PC. > +# 3. A single row INSERT is done which is after the PREPARE > +# 4. Then do a ROLLBACK PREPARED. > +# > +# Expect the 2PC data rolls back leaving only 3 rows on the subscriber. > +# (the original 2 + inserted 1) > +############################### > Fixed in v101. ------ Kind Regards, Peter Smith. Fujitsu Australia
