On Mon, Jul 19, 2021 at 3:28 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Wed, Jul 14, 2021 at 6:33 PM Peter Smith <smithpb2...@gmail.com> wrote: > > > > Please find attached the latest patch set v97* > > > > I couldn't spot spot any significant issues in the v97-0001 patch, but > do have the following trivial feedback comments: > > (1) doc/src/sgml/protocol.sgml > Suggestion: > > BEFORE: > + contains a Stream Prepare or Stream Commit or Stream Abort message. > AFTER: > + contains a Stream Prepare, Stream Commit or Stream Abort message. > > > (2) src/backend/replication/logical/worker.c > It seems a bit weird to add a forward declaration here, without a > comment, like for the one immediately above it > > /* Compute GID for two_phase transactions */ > static void TwoPhaseTransactionGid(Oid subid, TransactionId xid, char > *gid, int szgid); > - > +static int apply_spooled_messages(TransactionId xid, XLogRecPtr lsn); > > > (3) src/backend/replication/logical/worker.c > Other DEBUG1 messages don't end with "." > > + elog(DEBUG1, "apply_handle_stream_prepare: replayed %d > (all) changes.", nchanges); >
Thanks for the feedback. All these are fixed as suggested in v98. ------ Kind Regards, Peter Smith. Fujitsu Australia
