On Fri, Jun 11, 2021 at 8:56 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Amit Kapila <amit.kapil...@gmail.com> writes: > > On Fri, Jun 11, 2021 at 12:20 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > >> Another thing > >> I'm wondering is how many of these messages really need to be > >> translated. We could use errmsg_internal and avoid burdening the > >> translators, perhaps. > > > Not sure but I see all existing similar ereport calls don't use > > errmsg_internal. > > I was thinking maybe we could mark all these replication protocol > violation errors non-translatable. While we don't want to crash on a > protocol violation, it shouldn't really be a user-facing case either. >
I don't see any problem with that as these are not directly related to any user operation. So, +1 for making these non-translatable. -- With Regards, Amit Kapila.
