On Tue, May 25, 2021 at 2:47 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Tue, May 25, 2021 at 1:08 PM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> wrote: > > Thanks for the comments. I have addressed all comments to the v3 patch. > > Thanks! The patch basically looks good to me except that it is missing > a commit message. I think it can be added now.
With v3 patch, I observed failure in postgres_fdw test cases with insert query in prepared statements. Root cause is that in postgresGetForeignModifyBatchSize, fmstate can be null (see the existing code which handles for fmstate null cases). I fixed this, and added a commit message. PSA v4 patch. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
v4-0001-Adjust-batch_size-to-not-exceed-max-param-limit-o.patch
Description: Binary data
