On Sun, Mar 7, 2021 at 3:39 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > > > On 2021/03/06 5:37, Alvaro Herrera wrote: > > On 2021-Mar-05, James Coleman wrote: > > > >> Do you have any thoughts on what you'd like to see the message be? I > >> could change the PM_RECOVERY (without hot standby enabled) to return > >> CAC_RECOVERY which would give us the message "the database system is > >> in recovery mode", but that would be a change from what that state > >> returns now in a way that's unrelated to the goal of the patch. > > > > Here's an idea: > > > > * hot_standby=on, before reaching consistent state > > FATAL: database is not accepting connections > > DETAIL: Consistent state has not yet been reached. > > > > * hot_standby=off, past consistent state > > FATAL: database is not accepting connections > > DETAIL: Hot standby mode is disabled. > > > > * hot_standby=off, before reaching consistent state > > FATAL: database is not accepting connections > > This idea looks good to me!
+1. > > DETAIL: Hot standby mode is disabled. > > or maybe > > DETAIL: Consistent state has not yet been reached, and hot standby mode > > is disabled. > > I prefer the former message. Because the latter message meams that > we need to output the different messages based on whether the consistent > state is reached or not, and the followings would be necessary to implement > that. This looks a bit overkill to me against the purpose, at least for me. Agreed. If hot standby is off, why would the admin care about whether it's consistent yet or not? -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
