Hi, On 2020-08-13 12:50:16 -0400, Tom Lane wrote: > Stephen Frost <sfr...@snowman.net> writes: > > So, in our world, wouldn't this translate to 'make cfbot complain'? > > > I'm definitely a fan of the idea of having cfbot flag these and then we > > maybe get to a point where it's not the committers dealing with fixing > > patches that weren't pgindent'd properly, it's the actual patch > > submitters being nagged about it... > > Meh. Asking all submitters to install pgindent is a bit of a burden.
+1. We could improve on that by slurping it into src/tools though. If there were a 'make patchprep' target, it'd be a lot more realistic. But even so, it'd robably further inrease the rate of needing to constantly rebase lingering patches if cfbot considered indentation issues failures. E.g. because of typedefs.list updates etc. So I'm against that, even if we had a patchprep target that didn't need external tools. Greetings, Andres Freund
