On Wed, Jul 15, 2020 at 8:03 AM Amit Langote <amitlangot...@gmail.com> wrote: > > Hi Vignesh, > > On Tue, Jul 14, 2020 at 10:23 PM vignesh C <vignes...@gmail.com> wrote: > > On Tue, Jul 14, 2020 at 11:19 AM Amit Langote <amitlangot...@gmail.com> > > wrote: > > > Sounds fine to me. Although CopyLoadRawBuf() does not seem to a > > > candidate for rigorous code optimization as it does not get called > > > that often. > > > > I thought we could include that change as we are making changes around > > that code. > > Sure, done. > > > Rest of the changes looked fine to me. Also I noticed that > > commit message was missing in the patch. > > Please see the attached v7. >
Thanks for fixing the comments. Patch applies cleanly, make check & make check-world passes. The changes looks fine to me. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
