On 2020-04-08 13:16, Amit Langote wrote:
On Wed, Apr 8, 2020 at 6:26 PM Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
All committed.

Thank you and everyone very much for working on this.  I'm very happy
that these two features from PG10 have finally met. :)

Thanks a lot for reviewing and committing.

prion seems to have failed:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-04-08%2009%3A53%3A13

This comes from -DRELCACHE_FORCE_RELEASE.

Also, still unsure why the coverage report for pgoutput.c changes not good:
https://coverage.postgresql.org/src/backend/replication/pgoutput/pgoutput.c.gcov.html

I think this is because the END { } section in PostgresNode.pm shuts down all running instances in immediate mode, which doesn't save coverage properly.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Reply via email to