On Wed, Apr 8, 2020 at 1:22 AM Amit Langote <amitlangot...@gmail.com> wrote: > On Tue, Apr 7, 2020 at 6:01 PM Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: > > The descriptions of the new fields in RelationSyncEntry don't seem to > > match the code accurately, or at least it's confusing. > > replicate_as_relid is always filled in with an ancestor, even if > > pubviaroot is not set. > > Given this confusion, I have changed how replicate_as_relid works so > that it's now always set -- if different from the relation's own OID, > the code for "publishing via root" kicks in in various places. > > > I think the pubviaroot field is actually not necessary. We only need > > replicate_as_relid. > > Looking through the code, I agree. I guess I only kept it around to > go with pubupdate, etc.
Think I broke truncate replication with this. Fixed in the attached updated patch. -- Amit Langote EnterpriseDB: http://www.enterprisedb.com
v20-0001-Allow-publishing-partition-changes-via-ancestors.patch
Description: Binary data
v19-v20-delta.patch
Description: Binary data