On 2020-03-18 04:06, Amit Langote wrote:
+ if (isnull || !remote_is_publishable) + ereport(ERROR, + (errmsg("table \"%s.%s\" on the publisher is not publishable", + nspname, relname)));Maybe add a one-line comment above this to say it's an "not supposed to happen" error or am I missing something? Wouldn't elog() suffice for this?
On second thought, maybe we should just drop this check. The list of tables that is part of the publication was already filtered by the publisher, so this query doesn't need to check it again. We just need the relkind to be able to construct the COPY command, but we don't need to second-guess it beyond that.
-- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
