On Fri, Jan 24, 2020 at 6:56 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, Jan 24, 2020 at 01:28:29PM +0900, Arthur Zakirov wrote: > > It is compiled and passes the tests. There is the documentation and it is > > built too without an error. > > > > It seems that consensus about the returned type was reached and I marked the > > patch as "Ready for Commiter". > > + fsync_fname_ext(filename, S_ISDIR(fst.st_mode), false, ERROR); > One comment here: should we warn better users in the docs that a fsync > failule will not trigger a PANIC here? Here, fsync failure on heap > file => ERROR => potential data corruption.
Definitely yes.
