On Thu, Jan 16, 2020 at 09:51:24AM -0500, Robert Haas wrote: > On Tue, Jan 14, 2020 at 10:08 AM Atsushi Torikoshi <ato...@gmail.com> wrote: >> fails we can get error messages. So it seems straightforward for me to >> 'return true on success and emit an ERROR otherwise'. > > I agree with reporting errors using ERROR, but it seems to me that we > ought to then make the function return 'void' rather than 'bool'.
Yeah, that should be either ERROR and return a void result, or issue a WARNING/ERROR (depending on the code path, maybe PANIC?) with a boolean status returned if there is a WARNING. Mixing both concepts with an ERROR all the time and always a true status is just weird, because you know that if no errors are raised then the status will be always true. So there is no point to have a boolean status to begin with. -- Michael
signature.asc
Description: PGP signature
