Hello, Fujita-san. At Thu, 7 Nov 2019 17:20:07 +0900, Etsuro Fujita <etsuro.fuj...@gmail.com> wrote in > Only two people complaining about the wording? Considering as well > that we use that wording in the docs and there were no complains about > that IIRC, I don't feel a need to change that, TBH. > > > And perhaps "prepare" should be in > > upper case letters. > > Seems like a good idea. > > > Plus, any operation including a SELECT on a > > temporary table inhibits PREAPRE TRANSACTION, but the same on a > > postgres_fdw foreign tables is not. So the error message is rather > > wrong. > > > > A verbose alternative can be: > > > > "cannot PREPARE a transaction that has modified data on foreign tables > > using postgres_fdw" > > I don't think that's better, because that doesn't address the original > issue reported in this thread, as Gilles pointed out just before in > his email. See the commit message in the patch I posted.
"modified" is my mistake as in the just posted mail. But the most significant point in the previous mail is using "foreign tables using postgres_fdw" instead of "postgres_fdw foreign tables". And the other point is using different message from temporary tables. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
