Hi Michael-san, On Wed, Nov 6, 2019 at 1:13 PM Michael Paquier <mich...@paquier.xyz> wrote: > "postgres_fdw foreign tables" sounds weird to me. Could "foreign > tables using postgres_fdw" be a better wording? I am wondering as > well if we should not split this information into two parts: one for > the actual error message which only mentions foreign tables, and a > second one with a hint to mention that postgres_fdw has been used.
We use "postgres_fdw foreign tables" or "postgres_fdw tables" in release notes, so I thought it was OK to use that in error messages as well. But actually, these wordings are not suitable for error messages? > We could have more test cases with 2PC in this module, not necessarily > the responsibility of this patch, but while we're on it.. Agreed. Will do. Best regards, Etsuro Fujita
