On Mon, Apr 8, 2019 at 9:52 AM Fujii Masao <masao.fu...@gmail.com> wrote: > > On Sat, Apr 6, 2019 at 2:04 AM Robert Haas <robertmh...@gmail.com> wrote: > > > > On Thu, Apr 4, 2019 at 9:19 PM Masahiko Sawada <sawada.m...@gmail.com> > > wrote: > > > As INDEX_CLEANUP option has been added by commit a96c41f, the new > > > option for this feature could also accept zero or one boolean > > > argument, that is SHRINK_TABLE [true|false] and true by default. > > > Explicit options on VACUUM command overwrite options set by > > > reloptions. And if the boolean argument is omitted the option depends > > > on the reloptions. > > > > Yes, I think that's how it should work, because that's how the other > > option works, and there's no compelling reason to be consistent. > > > > My preference is for "truncate" over "shrink". > > +1 > > Attached is the updated version of the patch. > I just replaced "shrink" with "truncate" and rebased the patch > on the master.
Thank you for updating the patch! "vacuum_truncate" option would be more consistent with vacuum_index_cleanup option rather than "vacuum_truncate_enabled' option? > I'm thinking to commit this patch at first. > We can change the term and add the support of "TRUNCATE" option > for VACUUM command later. +1 Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
