On Fri, 5 Apr 2019 at 12:32, Andres Freund <and...@anarazel.de> wrote: > I've pushed this now. Besides those naming changes, I'd to re-add the > zero initialization (I did end up seing compiler warnings when compiling > with optimizations). Also some comment fixes.
Thanks for pushing. > I added one more flush location, when inserting into a partition that > cannot use batching - there might e.g. be triggers looking at rows in > other partitions or such. Good catch. I read through the final commit to see what had changed and I noticed that I had forgotten to remove nbuffers from CopyMultiInsertInfo when changing from a hash table to a List. Patch to fix is attached. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
remove_unused_variable_in_copy_buffers.patch
Description: Binary data
