On Thu, 4 Apr 2019 at 18:20, Andres Freund <and...@anarazel.de> wrote: > I'm pretty happy with this. I'm doing some minor changes (e.g. don't > like the function comment formatting that much, the tableam callback > needs docs, stuff like that), and then I'm going to push it tomorrow. > > I'm planning to attribute it to you, me, and Haribabu Kommi.
Sounds good. > > Oh, btw, is there a reason you're memset(0)'ing multiInsertInfo? Seems > unnecessary, given that in all cases we're using it we're going to do > CopyMultiInsertInfo_Init(). And IME valgrind and the compiler are more > helpful when you don't just default initialize, because then they can > tell when you forgot to initialize a field (say like > CopyMultiInsertInfo_Init not initializing nbuffers). At some point when I was hacking at it, I was getting a warning about it being possibly uninitialised. I don't recall exactly how the code was then, but I just tried removing it and I don't get any warning now. So probably fine to remove. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
