On Thu, Mar 7, 2019 at 7:35 AM Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote: > Thanks for the patch! > > The patch looks good to me, but one thing I'm wondering is: as suggested > by David, it would be better to rephrase this mention in the UPDATE > reference page, in a single commit: > > "Currently, rows cannot be moved from a partition that is a foreign > table to some other partition, but they can be moved into a foreign > table if the foreign data wrapper supports it." > > I don't think it needs to be completely rephrased; it's enough for me to > rewrite it to something like this: > > "Currently, rows cannot be moved from a foreign-table partition to some > other partition, but they can be moved into a foreign-table partition if > the foreign data wrapper supports tuple routing."
I prefer David's wording. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company