Greetings, While reviewing a bit of code around full page images, I came across a typo and fixed it in the attach.
Sending it here in case anyone feels that we should do more than just correct the word..? Perhaps for non-native English speakers seeing "whose" used here is confusing? If I don't hear any concerns then I'll go ahead and push it some time tomorrow; it's a pretty minor change, of course, and we can always adjust it further if someone raises an issue later too. Thanks! Stephen
From fb9b0f00396179af895c13e44bff98eee8302894 Mon Sep 17 00:00:00 2001 From: Stephen Frost <sfr...@snowman.net> Date: Tue, 27 Nov 2018 18:37:59 -0500 Subject: [PATCH] Fix typo Change: When wal_compression is enabled, a full page image which "hole" was removed is additionally compressed using PGLZ compression algorithm. to: When wal_compression is enabled, a full page image whose "hole" was removed is additionally compressed using PGLZ compression algorithm. As the correct word to use here is "whose", not "which". --- src/include/access/xlogrecord.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/access/xlogrecord.h b/src/include/access/xlogrecord.h index 863781937e..ccf92def93 100644 --- a/src/include/access/xlogrecord.h +++ b/src/include/access/xlogrecord.h @@ -114,7 +114,7 @@ typedef struct XLogRecordBlockHeader * XLOG record's CRC, either). Hence, the amount of block data actually * present is BLCKSZ - the length of "hole" bytes. * - * When wal_compression is enabled, a full page image which "hole" was + * When wal_compression is enabled, a full page image whose "hole" was * removed is additionally compressed using PGLZ compression algorithm. * This can reduce the WAL volume, but at some extra cost of CPU spent * on the compression during WAL logging. In this case, since the "hole" -- 2.17.1
signature.asc
Description: PGP signature
