Greetings, * Sergei Kornilov (s...@zsrv.org) wrote: > > I think I would have done 'if (targetSettingsCount != 1)' here. > Streaming replication does not have any recovery_target. > Well, i can check StandbyModeRequested too and allow 0 recovery_target only > for standby mode.
Ah. Agreed. > >> -# Multiple targets > >> -# Last entry has priority (note that an array respects the order of items > >> -# not hashes). > > > > You could (and imv should) include a test that throws an expected error > > if multiple targets are specified. > We have some example for checking unable-to-start DB? Did not find yet The TAP system in general supports expected failures, but that might only be with the simple binaries, not sure. I know src/bin/pg_dump has those though. > > Let’s at least fix the currently committed patch before adding new features > > or changing how things in recovery work. > +1 Thanks! Stephen
signature.asc
Description: PGP signature
