In-Reply-To: <20180928223240.kgwc4czzzekrp...@alap3.anarazel.de> Hi,
As discussed below (at [1]), I think we should remove $subject. I plan to do so, unless somebody protests soon-ish. I thought it'd be better to call attention to this in a new thread, to make sure people had a chance to object. Regards, Andres In "Something for the TODO list: deprecating abstime and friends" On 2018-09-28 15:32:40 -0700, Andres Freund wrote: > On 2017-12-13 00:05:06 -0800, Andres Freund wrote: > > > * contrib/spi/timetravel depends on abstime columns to represent what > > > would nowadays be better done as a tstzrange. I'd have thought we > > > could maybe toss that example module overboard, but we just today got > > > a question about its usage, so I'm afraid it's not quite dead yet. > > > What shall we do with that? > > > > Looking at the code I'd be pretty strongly inclined to scrap it. > > > > > > Before I'd discovered this thread, I'd started to write up a > > patch. Attached. It's clearly not fully done. Questions I'd while > > hacking things up: > > - what to do with contrib/spi/timetravel - I'd just removed it from the > > relevant Makefile for now. > > - nabstime.c currently implements timeofday() which imo is a pretty > > weird function. I'd be quite inclined to remove it at the same time as > > this. > > Here's a refreshed version of this patch. First patch removes > contrib/spi/timetravel, second patch removes abstime, reltime, tinterval > together with timeofday(). > > I think we should just go ahead and commit something like this soon. [1] http://archives.postgresql.org/message-id/20180928223240.kgwc4czzzekrpsid%40alap3.anarazel.de