Hi, On 2025-08-20 16:22:41 +0200, Antonin Houska wrote: > Álvaro Herrera <alvhe...@kurilemu.de> wrote: > > > On 2025-Aug-20, Antonin Houska wrote: > > > > > There's an issue with the symlink, maybe some meson expert can help. In > > > particular, the CI on Windows ends up with the following error: > > > > > > ERROR: Tried to install symlink to missing file > > > C:/cirrus/build/tmp_install/usr/local/pgsql/bin/vacuumdb > > > > Hmm, that's not the problem I see in the CI run from the commitfest app: > > > > https://cirrus-ci.com/task/5608274336153600 > > I was referring to the other build that you shared off-list (probably > independent from cfbot): > > https://cirrus-ci.com/build/4726227505774592 > > > [19:11:00.642] FAILED: [code=2] > > src/bin/scripts/vacuumdb.exe.p/vacuumdb.c.obj > > [19:11:00.642] "cl" "-Isrc\bin\scripts\vacuumdb.exe.p" "-Isrc\include" > > "-I..\src\include" "-Ic:\openssl\1.1\include" "-I..\src\include\port\win32" > > "-I..\src\include\port\win32_msvc" "-Isrc/interfaces/libpq" > > "-I..\src\interfaces\libpq" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" > > "/Od" "/Zi" "/Zc:preprocessor" "/DWIN32" "/DWINDOWS" "/D__WINDOWS__" > > "/D__WIN32__" "/D_CRT_SECURE_NO_DEPRECATE" "/D_CRT_NONSTDC_NO_DEPRECATE" > > "/wd4018" "/wd4244" "/wd4273" "/wd4101" "/wd4102" "/wd4090" "/wd4267" > > "/Fdsrc\bin\scripts\vacuumdb.exe.p\vacuumdb.c.pdb" > > /Fosrc/bin/scripts/vacuumdb.exe.p/vacuumdb.c.obj "/c" > > ../src/bin/scripts/vacuumdb.c > > [19:11:00.642] ../src/bin/scripts/vacuumdb.c(186): error C2059: syntax > > error: '}' > > [19:11:00.642] ../src/bin/scripts/vacuumdb.c(197): warning C4034: sizeof > > returns 0 > > > > The real problem here seems to be the empty long_options_repack array. > > I removed it and started a new run to see what happens. Running now: > > https://cirrus-ci.com/build/4961902171783168 > > The symlink issue occurred at "Windows - Server 2019, MinGW64 - Meson", where > the code compiled well. The compilation failure mentioned above comes from > "Windows - Server 2019, VS 2019 - Meson & ninja". I think it's still possible > that the symlink issue will occur there once the compilation is fixed.
FWIW, I don't think it's particularly wise to rely on symlinks on windows - IIRC they will often not be enabled outside of development environments. Greetings, Andres Freund
