> On Tue, May 06, 2025 at 11:50:07PM GMT, Junwang Zhao wrote: > Would it make sense to rename `RecordConstLocation` to something like > `RecordExpressionLocation` instead?
Yeah, naming is hard. RecordExpressionLocation is somehow more vague, but I see what you mean, maybe something along these lines would be indeed a better fit. > - /* Array of locations of constants that should be removed */ > + /* Array of locations of constants that should be removed and parameters */ > LocationLen *clocations; > > should be > > + /* Array of locations of constants and parameters that should be removed */ That was clumsy but intentional, because contrary to constants parameters do not need to be removed. I guess I have to change the wording a bit to make it clear.
