On Tuesday, November 19, 2024 5:10 PM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > On Tuesday, November 19, 2024 3:15 PM Shlok Kyal > <shlok.kyal....@gmail.com> wrote: > > > > > I noticed that we can add 'publish_generated_columns = true' for the case of > > generated column. So we won't need to remove the test. I have made the > > changes in v9 patch [1]. > > I think this would unexpectedly change the original purpose of that testcase, > which is to test the bug mentioned in commit b797def. > > Basically, I expected the new testcase to fail if we remove the codes fix > added in > b797def, but the new testcase can pass even after that.
Sorry, a typo here. I meant the commit adedf54 instead of b797def. > > If we confirmed that that bug will never be triggered after applying the fix > in > the thread, it would be better Tt remove that testcase and mention it in the > commit message. Best Regards, Hou zj
