On Tue, 3 Dec 2024 at 10:21, Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > On Friday, November 29, 2024 9:08 PM Shlok Kyal <shlok.kyal....@gmail.com> > wrote: > > > > > > Thanks for reviewing the patch. I have fixed the issue and updated the > > patch. > > Thanks for updating the patch. I have reviewed and have few suggestions. > > Please check the attached diff which includes: > > 1) Comments in CheckCmdReplicaIdentity() > * Removed some duplicate descriptions. > * Fixed the comments for the column list which I think is not correct. > * Mentioned the column list and generated column in XXX part as well. > > 2) Doc > * Since we mentioned the restriction for UPDATEs and DELTEs when row filter or > column list is defined in the create_publication.sgml, I feel we may need to > mention the generated part as well. So, added in the diff. > > 3) pub_contains_invalid_column > * Simplified one condition a bit. > > Please check and merge if it looks good to you. > The changes look good to me. I have included it in the updated patch.
Thanks and Regards, Shlok Kyal
v14-0001-Disallow-UPDATE-DELETE-on-table-with-generated-c.patch
Description: Binary data
