On Wed, Nov 13, 2024 at 3:53 AM Tomas Vondra <to...@vondra.me> wrote: > > > > On 11/13/24 10:38, Amit Kapila wrote: > > On Tue, Nov 12, 2024 at 6:29 PM Tomas Vondra <to...@vondra.me> wrote: > >> > >> Sure, maybe fixing LogicalIncreaseRestartDecodingForSlot() is enough to > >> fix this particular case. But I'd be happier if we could also add > >> asserts checking the LSN advances, to detect similar issues that we may > >> be unaware of yet. > >> > > > > As most of us lean towards fixing > > LogicalIncreaseRestartDecodingForSlot(), let's fix that in the HEAD > > and back branches. Separately we can consider other asserts just for > > HEAD that you think will make the code robust and help avoid such bugs > > in the future. > > > > +1 to that >
+1. Tomas, are you going to update the patch you shared before[1] or shall I? Regards, [1] https://www.postgresql.org/message-id/abf794c4-c459-4fed-84d9-968c4f0e2052%40vondra.me, 0004-fix-LogicalIncreaseRestartDecodingForSlot.patch -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
