On Tue, Nov 12, 2024 at 6:29 PM Tomas Vondra <to...@vondra.me> wrote: > > Sure, maybe fixing LogicalIncreaseRestartDecodingForSlot() is enough to > fix this particular case. But I'd be happier if we could also add > asserts checking the LSN advances, to detect similar issues that we may > be unaware of yet. >
As most of us lean towards fixing LogicalIncreaseRestartDecodingForSlot(), let's fix that in the HEAD and back branches. Separately we can consider other asserts just for HEAD that you think will make the code robust and help avoid such bugs in the future. -- With Regards, Amit Kapila.