On Mon, Sep 30, 2024 at 12:56 PM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi Shubham. Here are my review comment for patch v34-0002. > > ====== > doc/src/sgml/ref/create_publication.sgml > > 1. > + <para> > + This parameter can only be set <literal>true</literal> if > <literal>copy_data</literal> is > + set to <literal>false</literal>. > + </para> > > Huh? AFAIK the patch implements COPY for generated columns, so why are > you saying this limitation? > > ======
I have fixed this in the v36-0002 patch. > src/backend/replication/logical/tablesync.c > > 2. reminder > > Previously (18/9) [1 #4] I wrote maybe that other copy_data=false > "missing" case error can be improved to share the same error message > that you have in make_copy_attnamelist. And you replied [2] it would > be addressed in the next patchset, but that was at least 2 versions > back and I don't see any change yet. > This comment is still open. Will fix this and post in the next version of patches. Please refer to the updated v36-0002 Patch here in [1]. See [1] for the changes added. [1] https://www.postgresql.org/message-id/CAHv8Rj%2B1RDd7AnJNzOJXk--zcbTtU3nys%3DZgU3ktB4e3DWbJgg%40mail.gmail.com Thanks and Regards, Shubham Khanna.
