On Wed, Sep 25, 2024 at 11:15 PM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi, I have written a new patch to document this feature. > > The patch adds a new section to the "Logical Replication" chapter. It > applies atop the existing patches. > > v33-0001 (same as v32-0001) > v33-0002 (same as v32-0002) > v33-0003 (new DOCS) > > Review comments are welcome.
Thank you for updating the patch! I think that the patch doesn't have regression tests to check if generated column data is replicated to the subscriber as expected. I think we should include some tests for this feature (especially with other features such as column list). Also, when testing this feature, I got the following warning message even if the publication has publish_generated_columns = true: =# create publication pub for table test (a, c) with (publish_generated_columns = true); WARNING: specified generated column "c" in publication column list for publication with publish_generated_columns as false Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
