Hi Shubham. Here are my review comment for patch v34-0002. ====== doc/src/sgml/ref/create_publication.sgml
1. + <para> + This parameter can only be set <literal>true</literal> if <literal>copy_data</literal> is + set to <literal>false</literal>. + </para> Huh? AFAIK the patch implements COPY for generated columns, so why are you saying this limitation? ====== src/backend/replication/logical/tablesync.c 2. reminder Previously (18/9) [1 #4] I wrote maybe that other copy_data=false "missing" case error can be improved to share the same error message that you have in make_copy_attnamelist. And you replied [2] it would be addressed in the next patchset, but that was at least 2 versions back and I don't see any change yet. ====== [1] 18/9 review https://www.postgresql.org/message-id/CAHut%2BPusbhvPrL1uN1TKY%3DFd4zu3h63eDebZvsF%3Duy%2BLBKTwgA%40mail.gmail.com [2] https://www.postgresql.org/message-id/CAHv8RjJ5_dmyCH58xQ0StXMdPt9gstemMMWytR79%2BLfOMAHdLw%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
