On 2018-Jul-11, Michael Paquier wrote: > On Tue, Jul 10, 2018 at 04:23:42PM -0400, Tom Lane wrote: > > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > >> On 2018-Jul-10, Tom Lane wrote: > >>> I disagree --- including <float.h> in c.h, as this would have us do, > >>> seems like a huge expansion of the visibility of that header. Moreover, > >>> doing that only on Windows seems certain to lead to missing-header > >>> problems in the reverse direction, ie patches developed on Windows > >>> will fail elsewhere. > > > >> I don't think so, because that's only done for MSVC older than 2013. > >> Nobody uses that for new development anymore. > > > > Hm. OK, maybe it's all right given that. I'm still a bit worried > > about downsides, but no doubt the buildfarm will tell us. > > It seems to me that this patch is a good idea. Any objections if I take > care of it? I have a Windows VM with only MSVC 2015 if I recall > correctly though...
I just pushed it before seeing your message. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
