On Sat, Aug 10, 2024 at 9:29 AM Tom Lane <t...@sss.pgh.pa.us> wrote:
> "David G. Johnston" <david.g.johns...@gmail.com> writes: > > On Saturday, August 10, 2024, Tom Lane <t...@sss.pgh.pa.us> wrote: > >> That would break a lot of code (much of it not under our control) to > >> little purpose; it would also foreclose the option to return to using > >> SPI_ERROR_CONNECT someday. > > > I suggest we document it as deprecated and insist any future attempt to > > implement a return-on-error connection function define a completely new > > function. > > I don't > know if that usage pattern has propagated outside Postgres core, > but it might've. I'd give it decent odds since our example usage doesn't include the test. https://www.postgresql.org/docs/current/spi-examples.html /* Convert given text object to a C string */ command = text_to_cstring(PG_GETARG_TEXT_PP(0)); cnt = PG_GETARG_INT32(1); SPI_connect(); ret = SPI_exec(command, cnt); proc = SPI_processed; David J.
