On Saturday, August 10, 2024, Tom Lane <t...@sss.pgh.pa.us> wrote: > Stepan <sndc...@gmail.com> writes: > > Hi, hackers! If you look at the code in the src/backend/executor/spi.c > file, > > you will see the SPI_connect function familiar to many there, which > > internally simply calls SPI_connect_ext. The return type is int, at the > end > > it says return SPI_OK_CONNECT; > > It confuses me that nothing but OK, judging by the code, can return.(I > > understand that earlier, before 1833f1a1, it could also return > > SPI_ERROR_CONNECT). Therefore, I suggest making the returned value void > > instead of int and not checking the returned value. What do you think > about > > this? > > That would break a lot of code (much of it not under our control) to > little purpose; it would also foreclose the option to return to using > SPI_ERROR_CONNECT someday. >
I suggest we document it as deprecated and insist any future attempt to implement a return-on-error connection function define a completely new function. David J.
