On Fri, Jul 19, 2024 at 10:45 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > ====== > > src/include/replication/slot.h > > > > 1. > > -extern void ReplicationSlotAlter(const char *name, bool failover); > > +extern void ReplicationSlotAlter(const char *name, bool *failover, > > + bool *two_phase); > > > > Use const? > > > > If so, we need to use const both for failover and two_phase but not > sure if that is required here. We can evaluate that separately if > required by comparing it with similar instances. >
I checked and found that the patch uses const in walrcv_alter_slot_fn, so agree that we can change to const here as well. -- With Regards, Amit Kapila.
