On Wed, 19 Jun 2024 at 17:22, David G. Johnston <david.g.johns...@gmail.com> wrote: > > On Wed, Jun 19, 2024 at 8:19 AM Jelte Fennema-Nio <m...@jeltef.nl> wrote: > >> >> Because part of it would >> only be relevant once we support upgrading from PG18. So for now the >> upgrade_code I haven't actually run. > > > Does it apply against v16? If so, branch off there, apply it, then upgrade > from the v16 branch to master.
I realized it's possible to do an "upgrade" with pg_upgrade from v17 to v17. So I was able to test both the pre and post PG18 upgrade logic manually by changing the version in this line: if (fout->remoteVersion >= 180000) As expected the new pg_upgrade code was severely broken. Attached is a new patch where the pg_upgrade code now actually works.
v3-0001-Add-support-for-extensions-with-an-owned-schema.patch
Description: Binary data
