On Wed, May 15, 2024 at 6:33 AM Heikki Linnakangas <hlinn...@iki.fi> wrote:
> Ok, yeah, I can see that now. Here's a new version to address that. I
> merged ENC_SSL_NEGOTIATED_SSL and ENC_SSL_DIRECT_SSL to a single method,
> ENC_SSL. The places that need to distinguish between them now check
> conn-sslnegotiation. That seems more clear now that there is no fallback.
That change and the new comment that were added seem a lot clearer to
me, too; +1. And I like that this potentially preps for
encryption=gss/ssl/none or similar.
This assertion seems a little strange to me:
> if (conn->sslnegotiation[0] == 'p')
> {
> ProtocolVersion pv;
>
> Assert(conn->sslnegotiation[0] == 'p');
But other than that nitpick, nothing else jumps out at me at the moment.
Thanks,
--Jacob
